fix(docs): redirect base-path 404 + Java SDK in README#392
Merged
Conversation
📝 WalkthroughWalkthroughThis PR adds a Maven Central badge and Java SDK mentions to README.md, and fixes the docs redirect route to prepend the deployment base path (from import.meta.env.BASE_URL) to redirect and canonical URLs in the meta() function. ChangesREADME Java SDK Updates
Docs Redirect Base Path Fix
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The redirect stub's meta-refresh URL is resolved against the origin, not the router, so under the /taskito deploy base it dropped the prefix and 404'd (e.g. section-landing and old-URL redirects). Prefix import.meta.env.BASE_URL; the SPA navigate() path was already basename-aware.
Java is published to Maven Central (org.byteveda:taskito); list it in the SDK table, comparison, and badges alongside Python and Node.
pratyush618
force-pushed
the
fix/docs-redirect-basename
branch
from
July 8, 2026 04:43
e39d082 to
fcab92e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/app/routes/docs.$.tsx (1)
51-51: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueCanonical link uses a base-relative path, not an absolute URL.
hrefis only prefixed with the deploy base path, not the origin/scheme. Canonical tags are conventionally absolute URLs for SEO tooling; this is pre-existing behavior unrelated to the base-path bug being fixed here, but worth revisiting separately.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/app/routes/docs`.$.tsx at line 51, The canonical link in the docs route is currently built as a base-relative path instead of an absolute URL. Update the canonical URL generation in the docs route logic that emits the link tag so `href` includes the full origin and scheme, not just the deploy base path, while keeping the base-path handling intact for the existing fix. Use the canonical link creation in `docs.$.tsx` as the place to adjust the URL assembly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/app/routes/docs`.$.tsx:
- Line 51: The canonical link in the docs route is currently built as a
base-relative path instead of an absolute URL. Update the canonical URL
generation in the docs route logic that emits the link tag so `href` includes
the full origin and scheme, not just the deploy base path, while keeping the
base-path handling intact for the existing fix. Use the canonical link creation
in `docs.$.tsx` as the place to adjust the URL assembly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bb9dcfb3-4447-43ee-ad3e-eae8577bbcae
📒 Files selected for processing (2)
README.mddocs/app/routes/docs.$.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirect base-path 404 + Java SDK in README
1. Redirect meta-refresh dropped the deploy base path (404)
Follow-up to #391. The redirect stub's
meta-refreshURL is resolved against the origin, not the router — so under the/taskitodeploy base it emittedurl=/python/getting-started/installation(no prefix) and the host 404'd. The SPAnavigate()path was already basename-aware; only the static meta tag wasn't.Fix: prefix
import.meta.env.BASE_URLon the refresh + canonical URLs. This also repairs the pre-existingarchitecture/more/*/resourcesredirects, which had the same latent bug.Verified with a production-basename build (
DOCS_BASE_PATH=/taskito): stubs now emiturl=/taskito/….2. Java SDK in the README
Java is published to Maven Central (
org.byteveda:taskito) but the root README still listed only Python and Node. Added it to the SDK table, the comparison row, and a Maven Central badge.Summary by CodeRabbit
Documentation
Bug Fixes